Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update go table driven tests link in CODING_GUIDELINES.md #22040

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

beepdeepor
Copy link
Contributor

@beepdeepor beepdeepor commented Oct 2, 2024

Description

https://github.com/golang/go/wiki/TableDrivenTests is no longer valid, replaced by https://go.dev/wiki/TableDrivenTests

Summary by CodeRabbit

  • Documentation
    • Revised the CODING_GUIDELINES.md to enhance clarity on coding practices, performance, security, documentation, acceptance tests, automated tests, and quality assurance.
    • Introduced structured guidelines for API & Design, Performance, Security, Documentation, Acceptance Tests, Automated Tests, and Quality Assurance.
    • Recommended using diagrams or flowcharts for complex code to aid understanding.

@beepdeepor beepdeepor requested a review from a team as a code owner October 2, 2024 07:03
Copy link
Contributor

coderabbitai bot commented Oct 2, 2024

📝 Walkthrough

Walkthrough

The CODING_GUIDELINES.md document has been extensively revised to improve clarity and detail regarding various coding practices, including API design, performance, security, documentation, acceptance tests, automated tests, and quality assurance. Key areas of focus include structured code principles, efficient coding practices, security considerations, and enhanced testing frameworks. The revisions aim to provide a comprehensive framework for coding standards within the project.

Changes

File Change Summary
CODING_GUIDELINES.md Significant revisions made to enhance clarity and detail on coding practices, performance, security, documentation, acceptance tests, automated tests, and quality assurance.

Possibly related PRs

Suggested reviewers

  • sontrinh16
  • julienrbrt

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tac0turtle tac0turtle enabled auto-merge October 2, 2024 07:06
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)
CODING_GUIDELINES.md (2)

107-107: Approve link update and suggest hyphenation correction

The update to the table-driven tests link is correct and now points to the official Go documentation. This change improves the accuracy of the guidelines.

Additionally, for consistency with common usage and to address the static analysis hint:

Consider applying this minor change:

-[table driven tests](https://go.dev/wiki/TableDrivenTests)
+[table-driven tests](https://go.dev/wiki/TableDrivenTests)

This hyphenation is more commonly used and aligns with the spelling in the linked documentation.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~107-~107: The adjective “table-driven” is spelled with a hyphen.
Context: ... of different inputs, we prefer to use [table driven tests](https://go.dev/wiki/TableDrivenT...

(DRIVEN_HYPHEN)


[uncategorized] ~107-~107: The adjective “Table-driven” is spelled with a hyphen.
Context: ...(https://go.dev/wiki/TableDrivenTests). Table driven test error messages should follow the f...

(DRIVEN_HYPHEN)


107-107: Suggest consistent hyphenation

For consistency with the previous suggestion and to address the static analysis hint:

Consider applying this minor change:

-Table driven test error messages should follow the following format
+Table-driven test error messages should follow the following format

This maintains consistency in hyphenation throughout the document.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~107-~107: The adjective “table-driven” is spelled with a hyphen.
Context: ... of different inputs, we prefer to use [table driven tests](https://go.dev/wiki/TableDrivenT...

(DRIVEN_HYPHEN)


[uncategorized] ~107-~107: The adjective “Table-driven” is spelled with a hyphen.
Context: ...(https://go.dev/wiki/TableDrivenTests). Table driven test error messages should follow the f...

(DRIVEN_HYPHEN)

📜 Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between fc28210 and a629781.

📒 Files selected for processing (1)
  • CODING_GUIDELINES.md (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
CODING_GUIDELINES.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

🪛 LanguageTool
CODING_GUIDELINES.md

[uncategorized] ~107-~107: The adjective “table-driven” is spelled with a hyphen.
Context: ... of different inputs, we prefer to use [table driven tests](https://go.dev/wiki/TableDrivenT...

(DRIVEN_HYPHEN)


[uncategorized] ~107-~107: The adjective “Table-driven” is spelled with a hyphen.
Context: ...(https://go.dev/wiki/TableDrivenTests). Table driven test error messages should follow the f...

(DRIVEN_HYPHEN)

@tac0turtle tac0turtle added this pull request to the merge queue Oct 2, 2024
Merged via the queue into cosmos:main with commit c85fbae Oct 2, 2024
70 of 73 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants